On Wed, Sep 04, 2013 at 09:47:12AM -0700, Junio C Hamano wrote: > Jonathan Nieder <jrnie...@gmail.com> writes: > > > test_cmp_rev follows the same order of arguments a "diff -u" and > > produces the same output as plain "git diff". It's perfectly readable > > and normal. > > This is way off tangent, but I am somewhat sympathetic to Felipe's > "compare actual with expect", with reservations.
This isn't an argument either way, but note that JUnit (and NUnit and PHPUnit) all have assertEquals methods that take the arguments in the order "expect, actual". I've always assumed that Git's test framework was imitating that, although I have no idea why that particular order is chosen and is so common. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
