Kyle J. McKay wrote: > The longer comment looks good to me. If you think the code will be safe from > simplification patches without a comment, that works for me too.
I think if we can't trust reviewers to catch this kind of thing, we're in trouble (i.e., moving too fast). :) So FWIW my instinct is to leave the comment out, since I actually find it more readable that way (otherwise I would wonder, "Why am I being told that a strbuf's buffer has a nonconstant address? Do some other strbufs have a constant address or something?") Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
