On Tue, Sep 17, 2013 at 6:17 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Keeping the ugliness to deal with the platform issue (i.e. broken > string.h) in one place (e.g. compat/mingw) is far more preferrable > than having a similar ugliness in git-compat-util.h for people on > all other platforms to see, no? I don't think people on other platforms seeing the ugliness is really an issue. After all, the file is called git-*compat*-util.h; I sort of expect to see such things there, and I would expect only more complex compatibility stuff that requires multiple files in the compat/ directory. Also, your solution does not really keep the ugliness in one place, you need the change in config.mak.uname, too (because yes, I do insist to avoid GCC-ism in C files, just like you probably would insist to avoid Bash-ism in shell scripts). -- Sebastian Schuberth -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
