Jeff King <p...@peff.net> writes:

> On Fri, Oct 18, 2013 at 11:25:13AM -0700, Junio C Hamano wrote:
>
>> Jeff King <p...@peff.net> writes:
>> 
>> > + * Our basic strategy is to compare "base" and "asked" to find the bits
>> > + * specific to our request. We then strip those bits off of "got" to 
>> > yield the
>> > + * new base. So for example, if our base is "http://example.com/foo.git";,
>> > + * and we ask for "http://example.com/foo.git/info/refs";, we might end up
>> > + * with "https://other.example.com/foo.git/info/refs";. We would want the
>> > + * new URL to become "https://other.example.com/foo.git";.
>> 
>> Not "https://other.example.com/foo.git/info/refs";?
>
> I think my use of "the new URL" is ambiguous. I meant "the new base",
> from which one could then construct the new refs URL as you suggest.

Ahh, there is nothing we need to do to make the new URL to
"https://.../info/refs";; we already have it in "got".  And the
function resets "base" and then adds "got" excluding its tail part
to compute the new base.  So "s/new URL/new base/" would be all we
need to do, I think.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to