On Wed, Oct 23, 2013 at 10:56:32PM +0000, brian m. carlson wrote: > On Tue, Oct 22, 2013 at 08:21:48PM -0700, Shawn Pearce wrote: > > From my perspective, it is OK to defaulting to use 100-continue if the > > server supports Negotiate. If the user is stuck behind a broken proxy > > and can't authenticate, they can't authenticate. They can either set > > the variable to false, or fix their proxy, or use a different server, > > etc. > > I think Jonathan's suggestion was to get rid of the variable altogether > and simply make the code conditional on whether the server is offering > GSS-Negotiate. I plan to make the use of 100-continue conditional on > large_request as well, so that it only covers the case where it would > otherwise fail.
I think that makes sense. Would you also want to suppress the probe request in that case? It serves the same purpose, but would cause you to do an extra auth for no reason (which potentially means user input, which is annoying). Also, if I recall your original complaint correctly, the "Expect" handling was only half of the problem. Wasn't there also an issue where git prompts for a password, even though GSS-Negotiate doesn't use it? Do you have a plan for that? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
