Hi Jonathan, On Fri, 27 Dec 2013, Jonathan Nieder wrote:
> Johannes Schindelin wrote: > > > it returns EOF only if ch == EOF *and* sb->len == 0, i.e. if no characters > > have been read before hitting EOF. > > Yep. api-strbuf.txt even says so. I never bothered to look ;-) > Sorry for the nonsense. Nope, no nonsense at all. I actually had a look only after your review, and it definitely makes sense to double-check. > For what it's worth, > Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> It is worth a lot. Believe me, I know just how thankless a task reviewing is, and instead of getting praise for it, you even get abused by contributors who would rather self-review their code for fear of having a twist in their knockers pointed out publicly. Your review makes the code better, even if it does not result in code changes all the time: it increases the confidence that the code is good. Thank you, Jonathan! Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
