2014/1/7 Junio C Hamano <gits...@pobox.com>: > Francesco Pretto <cez...@gmail.com> writes: > >> According to "Documentation/gitmodules.txt", 'checkout' is a valid >> 'submodule.<name>.update' command. > > As you can see in the surrounding text, we call the value of > submodule.*.update a "mode", not a command. >
Ok. >> Also "git-submodule.sh" refers to >> it and processes it correctly. > > This present tense puzzles me. If it already refers to checkout and > handles it correctly is there anything that needs to be done? Or > did you mean "it should refer to and process it but it doesn't, so > make it so?" > Like you said, "it already refers to checkout and handles it correctly". I think the use of the simple present tense here is correct: it's a fact. Feel free to advice another wording if you prefer. >> Reflecting commit 'ac1fbb' to support >> this syntax and also validate property values during 'update' command, >> issuing an error if the value found is unknown. > > Sorry, but -ECANNOTPARSE. Not sure what's wrong here, can you explain why it's failing? I'm using git-format-patch/git-send-email with default settings. Also, if you can edit and keep the sign-off (I'm not familiar with the mailing-list maintainer workflow, sorry), feel free to do it. Thanks -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
