Hi kusma, On Tue, 21 Jan 2014, Erik Faye-Lund wrote:
> On Tue, Jan 21, 2014 at 12:25 AM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: > > > > On Mon, 20 Jan 2014, Torsten Bögershausen wrote: > > > >> b) add "+++" at the places where you added the stat() and chmod(), > >> c) and to send the question "is this a good implementation ?" to upstream > >> git. > >> > >> I think your implementation makes sense. > > > > As I said in my other reply, I think that the problem would be > > addressed more generally in compat/mingw.c. It is to be doubted highly > > that upstream wants to handle cases such as "rename() cannot overwrite > > read-only files on Windows" everywhere they call rename() because the > > platforms upstream cares about do not have that problem. > > I'm not so sure. A quick test shows me that this is not the case for > NTFS. Since this is over a network-share, the problem is probably > server-side, and can affect other systems as well. > > So a work-around might be appropriate for all systems, no? I do not think that the problem occurs if you run the same commands on Linux, on a mounted Samba share. So I guess that upstream Git can enjoy their luxury of not having to care. In any case, if we would need this also for Linux, doing it for only one user of rename() would probably not be good enough, either... so something similar to mingw_rename() would be needed (interfering with mingw_rename itself, of course). Ciao, Dscho
