Patch 17/17 of v4 failed to arrive in my inbox for some reason, so I'll just reply to v3 since there's another error I noticed which is still present in v4, plus a comment specific to v4 (see below).
On Mon, Jan 27, 2014 at 3:33 PM, Christian Couder <chrisc...@tuxfamily.org> wrote: > From: Eric Sunshine <sunsh...@sunshineco.com> >> On Sun, Jan 26, 2014 at 12:00 PM, Christian Couder >> <chrisc...@tuxfamily.org> wrote: >>> +By default, a 'token=value' or 'token:value' argument will be added >>> +only if no trailer with the same (token, value) pair is already in the >>> +message. The 'token' and 'value' parts will be trimmed to remove >>> +starting and trailing white spaces, and the resulting trimmed 'token' >> >> Other git documentation uniformly spells it as "whitespace" rather >> than "white spaces". > > You are right I will change that. The rest of git documentation consistently spells it "whitespace", but v4 uses "whitespaces". >>> +----infile=file:: >>> + Read the commit message from `file` instead of the standard >>> + input. I didn't notice this when reviewing v3, and the same text appears in v4. There are a couple extra hyphens before 'infile', and you want < and > around "file", so: s/----infile=file/--infile=<file>/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
