On Mon, Feb 10, 2014 at 3:19 AM, Torsten Bögershausen <tbo...@web.de> wrote: > > On 2014-02-08 09.53, Duy Nguyen wrote: >>>> file-watcher.c | 32 ++++++++++++++++++++++++++++++++ >>>> 1 file changed, 32 insertions(+) >>> >>> I feel a little bit unsure about the 700. >>> Most often Git does not care about permissions, >>> and relies on umask being set appropriatly. >>> (Please correct me if I'm wrong) >> >>Git does care. See credential-cache--daemon.c. In fact this function >>is a copy of check_socket_directory() from that file. >> > I was probably a little bit unclear. > Of course credentials should be protected well and stored with 700. > The rest of the repo could be more loose by using adjust_shared_perm(). > Because the whole repo can be shared (or not) and data is visible > to the group or everyone. > (this is a minor issue)
So how about a check whenever a worktree is connected to the daemon, if that worktree has stricter permission, e.g. 0700 vs 0770 of the daemon socket directory, then the daemon refuses the worktree (maybe with a warning)? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
