Duy Nguyen <pclo...@gmail.com> writes: > On Thu, Feb 27, 2014 at 7:22 AM, Junio C Hamano <gits...@pobox.com> wrote: >> Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes: >> >>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com> >>> --- >> >> It is a good thing to do to read config from the real repository we >> are borrowing from when we have .git/commondir, but it makes me >> wonder if we should signal some kind of error if we find .git/config >> in such a borrowing repository---which will be silently ignored. >> >> My gut feeling is that such a check may be necessary, but may not >> belong to this function. > > Just checking. Once we do this, what about .git/refs/.. that is also > ignored in such a repo?
It was just that I became aware of the issue while reading this patch to check-repository-format which is only about config, but anything inside .git/ of the borrowing repository that are ignored because it has .git/common-dir (including .git/refs) should be a cause of the same error, I would say. That would be the same set as symlinks created by contrib/workdir/git-new-workdir script. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
