Junio C Hamano <gits...@pobox.com> writes: > Benoit Pierre <benoit.pie...@gmail.com> writes: > >> Signed-off-by: Benoit Pierre <benoit.pie...@gmail.com> >> --- >> t/t7505-prepare-commit-msg-hook.sh | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/t/t7505-prepare-commit-msg-hook.sh >> b/t/t7505-prepare-commit-msg-hook.sh >> index 604c06e..1be6cec 100755 >> --- a/t/t7505-prepare-commit-msg-hook.sh >> +++ b/t/t7505-prepare-commit-msg-hook.sh >> @@ -167,7 +167,7 @@ test_expect_success 'with failing hook' ' >> head=`git rev-parse HEAD` && >> echo "more" >> file && >> git add file && >> - ! GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit -c $head >> + test_must_fail env GIT_EDITOR="\"\$FAKE_EDITOR\"" git commit -c $head > > Thanks. It is good that you avoided the common pitfall of attempting > > GIT_EDITOR=... test_must_fail git commit -c $head ;# WRONG > > but do we assume everybody has "env"?
It turns out that the answer to this question seems to be "yes, we already do."; so the patch is probably OK as-is. Thanks. > To be portable, we can do this instead. > > ( > GIT_EDITOR=... && > export GIT_EDITOR && > test_must_fail git commit -c $head > ) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
