On Mon, Mar 10, 2014 at 07:49:37PM +0100, Benoit Pierre wrote: > --- > run-command.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/run-command.h b/run-command.h > index 88460f9..3653bfa 100644 > --- a/run-command.h > +++ b/run-command.h > @@ -51,6 +51,7 @@ extern int run_hook_le(const char *const *env, const char > *name, ...); > extern int run_hook_ve(const char *const *env, const char *name, va_list > args); > > LAST_ARG_MUST_BE_NULL > +__attribute__((deprecated))
It doesn't appear that we use the deprecated attribute anywhere else in the code. Wouldn't it just be better to change the places that use this and then remove the function altogether? I imagine your current patch might introduce a number of warnings that some people would rather avoid. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
