Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes: > Option explanation is in rev-list-options.txt. The interaction with -z > is left undecided. > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com> > --- > On Fri, Mar 21, 2014 at 2:15 AM, Junio C Hamano <gits...@pobox.com> wrote: > >> * Get rid of saved_linear, use another flag in struct object instead > > > > I cannot offhand say if I like this change or not. A flag bit is a > > scarce and limited resource; commit slabs felt more suited for > > implementation of corner case eye-candies. > > I leave it in bit 26. We can move it out when we run low on flag bits. > > >> * Fix not showing the break bar after a root commit if the dag graph > >> has multiple roots > > > > I definitely do not like the way a commit-list data structure is > > abused to hold a phoney element that points at a NULL with its item > > pointer. Allocate a single bit in revs that says "I haven't done > > anything yet" if you want to catch the "first-ness" without breaking > > what commit_list_insert() and friends are expecting to see---they > > never expect to see a NULL asked to be on the list, AFAIK. > > Fixed. > > >> * Make it work with --graph (although I don't really see the point of > >> using both at the same time) > > > > I do not see the point, either. I vaguely recall that the previous > > iteration refused the combination at the option parser level, which > > I think would be the right thing to do. > > Fixed.
All changes look good to me. Especially on the last one because the new "printf()" calls do not even attempt to call into the graph API to tell it that it created a gutter above or give it a chance to draw all vertical lines to connect the graph part. Will replace and advance them to "Will merge to 'next'" state. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
