Duy Nguyen <pclo...@gmail.com> writes: > On Sat, Mar 29, 2014 at 5:21 AM, Junio C Hamano <gits...@pobox.com> wrote: >> * nd/gc-aggressive (2014-03-17) 4 commits >> - gc --aggressive: three phase repacking >> - gc --aggressive: make --depth configurable >> - pack-objects: support --keep >> - environment.c: fix constness for odb_pack_keep() > > Using --before=1.year.ago my way does not keep all recent chains short > because commit time is unreliable. But even with better recent object > selection, the performance gain is still within noise level. I suggest > we keep " gc --aggressive: make --depth configurable" and drop the > rest.
I think the three-phase thing may not be so well conceived or cooked, but the other three looked like reasonable changes, although it would have been easier to say so if "pack-objects --keep" were done without a new buffer of size PATH_MAX ;-) Let's do the const and --depth and discard the other two. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
