On Wed, Apr 02, 2014 at 08:52:17AM +0200, Torsten Bögershausen wrote:

> +             /*
> +              * loose.  The loose file name is the same as the
> +              * lockfile name, minus ".lock":
> +              */
> +             char *loose_filename = xmemdupz(lock->lk->filename,
> +                                             strlen(lock->lk->filename) - 5);
> 
> At other places (lockfile.c) we use this
> 
> +#define LOCK_SUFFIX_LEN 5
> 
> I think it makes sense to move this definition to an include file (lockfile.h 
> ??)
> and use it here.

I had the same comment, but if you read through to patch 18, this manual
munging goes away entirely, and the end result is much cleaner.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to