Jonathan Nieder <jrnie...@gmail.com> writes: > Should the internal patch-id computation used by commands like 'git > cherry' (see diff.c::diff_get_patch_id) get the same change? (Not a > rhetorical question --- I don't know what the right choice would be > there.)
I thought about it but I did not think of a reason why. If we do not store the patch-id (it would be a misnomer especially after this series, it is mor like patch signature), and we generate the patch to be hashed internally without getting affected by any user input given per-invocation, then nothing is externally observable even if we used two completely different definition of patch id computation, and I think these preconditions do hold. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
