On Sun, May 04, 2014 at 08:52:44PM +0200, Stepan Kasal wrote: > Thank you very much for this analysis. > It enables us to redirect you the third time: to report this as a > bug in MinGW-W64 ! ;-)
I'll report this to MinGW-W64 soon, though even if/when they fix the issue on their side, I'd still like to have a workaround in Git to be able to use older MinGW-W64 versions that didn't receive a fix. > Seriously, it looks you found the best description of the problem, > and it would be nice if you could modify your patch so that it > is really a work around: it would be in effect only for MinGW-W64, > and the comment would explain that this is a hack to work around the > bug. Workarounds do not have to be ugly and full of #ifdef's. > If you manage to change the defs for poll.c without changing its > content, no one could tell you to report to gnulib first. v1 does exactly this. > OTOH, if MsgWaitForMultipleObjects is present ustream (in gnulib's > poll.c, sorry that I cannot check right now), it still might be > better to submit the work-around there first. Workaround is "just don't pass -DNOGDI on MinGW-W64 if you want MsgWaitForMultipleObjects", there's nothing to send to gnulib. After all, was there a strong reason why Git started passing it? What is there was no option to disable part of windows.h? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
