On Thu, May 15, 2014 at 09:37:05AM +0200, Per Cederqvist wrote: > On Wed, May 14, 2014 at 5:53 PM, Jeff Sipek <jef...@josefsipek.net> wrote: > > On Tue, May 13, 2014 at 10:31:04PM +0200, Per Cederqvist wrote: ... > >> + > >> +for i in `seq 5`; do > >> + if [ $i -ge 5 ]; then > >> + shouldfail guilt pop > >> + else > >> + cmd guilt pop > >> + fi > >> + cmd git for-each-ref > >> + cmd guilt push > >> + cmd git for-each-ref > >> + cmd guilt pop > >> + cmd git for-each-ref > >> +done > >> + > >> +# Check that "pop -a" does the right thing. > > > > What exactly is the right thing? no-op since the above loop poped > > everything? (I'd make the comment say what the "right thing" is.) > > I'll rephrase that block of code like this: > > # Check that "pop -a" properly pops all patches. > cmd guilt push -a > cmd git for-each-ref > cmd guilt pop -a > cmd git for-each-ref > > Is that more clear? The test pushes all patches, checks that they > are applied, removes them, checks that it worked.
Yeah. Thanks, Jeff. -- NT is to UNIX what a doughnut is to a particle accelerator. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
