On Thu, May 22, 2014 at 03:52:08PM -0700, Kyle J. McKay wrote: > >Christian brought this up elsewhere, and I agree it's probably better to > >work over the whole buffer, NULs included. I'm happy to re-roll (or you > >can just pick up the version of the patch in this thread), > > The only reason I brought up the code difference in the first place was that > the comment was "This makes config's lowercase() function public" which made > me expect to see basically the equivalent of replacing a "static" with an > "extern", but actually the function being made public was a different > implementation than config's lowercase() function. So it looks like the > original PATCH 2/9 version of the code is best, but perhaps the comment can > be tweaked a bit to not convey the same impression I got. Maybe something > like "Replace config's lowercase() function with a public one".
Yeah, sorry if it sounded like I was complaining about your review elsewhere. I mostly found it amusing that I got two opposite-direction reviews. I agree that clarifying the situation in the commit message is best, and I've done that in the version I just posted. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
