Hello, On Wed, Jun 04, 2014 at 08:47:58PM +0700, Duy Nguyen wrote: > setenv("HOME") if it's missing instead? MinGW port already replaces > main(). Extra initialization should not be a problem.
well, I would be afraid to modify the environment for subprocesses. It could hit back in certain situations, like with git filter-branch. We could replace getenv() with a wrapper though. But I don't think it's worth it. > I feel > "getenv("HOME")" a tiny bit more familiar than get_home_directory(), > but that's really weak argument as the number of call sites has not > increased in 4 years. Actually, the patch had to be updated when msysgit modifications were rebased. But yes, the number of call sites has not icreased: it was called in four places back than, and it is called at three places now. There is only one that is in common, though. Stepan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html