On Monday, June 9, 2014, Jeff King <p...@peff.net> wrote: > For both of these sites, we already do the "fallback to > read_sha1_file" trick. But we can shorten the code by just > using get_commit_buffer. > > Note that the error cases are slightly different when > read_sha1_file fails. get_commit_buffer will die() if the > object cannot be loaded, or is a non-commit. > > For get_sha1_oneline, this will almost certainly never > happen, as we will have just called parse_object (and if it > does, it's probably worth complaining about). > > For record_author_date, the new behavior is probably better; > we notify the user of the error instead of silently ignoring > it. And because it's used only for sorting by author-date, > somebody examining a corrupt can fallback to the regular
Missing word here? "examining a corrupt [...] can" > traversal order. > > Signed-off-by: Jeff King <p...@peff.net> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
