Jeff King venit, vidit, dixit 13.06.2014 13:51: > On Fri, Jun 13, 2014 at 12:42:47PM +0200, Michael J Gruber wrote: > >> test_expect_success GPG 'detect fudged signature' ' >> git cat-file commit master >raw && >> >> sed -e "s/seventh/7th forged/" raw >forged1 && >> git hash-object -w -t commit forged1 >forged1.commit && >> + ! git verify-commit $(cat forged1.commit) && > > Please use test_must_fail here (and further down), which will catch > things like signal death.
Again, that is an issue of keeping the style of the surrounding code (which is relatively new) vs. doing it differently. I don't mind changing t7510 to a different style, though. Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
