On Fri, Jun 20, 2014 at 4:32 PM, Karsten Blees <karsten.bl...@gmail.com> wrote: > Am 21.06.2014 00:33, schrieb Junio C Hamano: >> Karsten Blees <karsten.bl...@gmail.com> writes: > > GIT_TRACE_VERBOSE perhaps? It affects all trace output, not just > GIT_TRACE_PERFORMANCE. The tests would still have to disable it > explicitly, though, in case someone sets it in their profile. > > However, IIRC conclusion of v4 discussion was that this would be > useful for all trace output [1], so I think it should be the default. > > [1] https://groups.google.com/forum/#!topic/msysgit/UMKTvmZX5aI
Hmph, after re-reading of that thread, I recall that I thought Peff's >> Would it make >> sense to just tie this to regular trace_* calls, and if >> GIT_TRACE_PERFORMANCE is set, add a timestamp to each line? was the conclusion (i.e. by default no change, ask with GIT_TRACE_PERFORMANCE), and that I found that reasonable back then. As to the need to disable in the tests, yes, you are right. Just like we give predictiable environment to tests by setting EDITOR, HOME, etc. in test-lib.sh, we should do the same for these new settings there. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
