On Wed, Jul 2, 2014 at 11:05 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <chrisc...@tuxfamily.org> writes: > >> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> >> --- >> builtin/replace.c | 42 +++++++++++++++++++++++++----------------- >> 1 file changed, 25 insertions(+), 17 deletions(-) >> >> diff --git a/builtin/replace.c b/builtin/replace.c >> index 3515979..ad47237 100644 >> --- a/builtin/replace.c >> +++ b/builtin/replace.c >> @@ -295,27 +295,14 @@ static int edit_and_replace(const char *object_ref, >> int force) >> return replace_object_sha1(object_ref, old, "replacement", new, force); >> } >> >> -static int create_graft(int argc, const char **argv, int force) >> +static void replace_parents(struct strbuf *buf, int argc, const char **argv) > > It is somewhat strange to see that a new function introduced earlier > in the series is rewritten with a "refactoring". Shouldn't the new > function have been done right from the beginning instead?
Yeah, I will do it right from the beginning in the next patch series. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
