On Sat, Jul 12, 2014 at 03:55:35PM +0100, Ramsay Jones wrote:

> >     if (!obj) {
> >             struct commit *c = alloc_commit_node();
> > -           return create_object(sha1, OBJ_COMMIT, c);
> > +           return create_object(sha1, c);
> >     }
> 
> perhaps:
>       if (!obj)
>               return create_object(sha1, alloc_commit_node());
> 
> (increasing similarity with other calls here ...)

Yeah, I noticed that but didn't change it to keep the diff small. The
one that should have is 969eba6, but it is not a big deal to do it here.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to