Junio C Hamano <gits...@pobox.com> writes: > John Keeping <j...@keeping.me.uk> writes: > >> Signed-off-by: John Keeping <j...@keeping.me.uk> >> --- > > As these ;; are separators not terminators, this is not strictly > necessary. Squashing it into a change that adds more case arms to > this case statement is of course not just good but necessary, > though.
s/necessary/may be &/; if you add new arms before this one, you won't need it. But if you add one after this, you would ;-). >> contrib/completion/git-completion.bash | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/contrib/completion/git-completion.bash >> b/contrib/completion/git-completion.bash >> index 7a6e1d7..d0b2895 100644 >> --- a/contrib/completion/git-completion.bash >> +++ b/contrib/completion/git-completion.bash >> @@ -1627,6 +1627,7 @@ _git_push () >> --repo) >> __gitcomp_nl "$(__git_remotes)" >> return >> + ;; >> esac >> case "$cur" in >> --repo=*) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
