On Sat, Aug 23, 2014 at 09:29:36AM +0200, Michael Haggerty wrote: > > [1/5]: git-prompt: do not look for refs/stash in $GIT_DIR > > [2/5]: pack-refs: prune top-level refs like "refs/foo" > > [3/5]: fast-import: clean up pack_data pointer in end_packfile > > [4/5]: fast-import: fix buffer overflow in dump_tags > > [5/5]: fast-import: stop using lock_ref_sha1 > > +1 on patches 1 and 2 > Patch 3 is outside of my area of competence > +1 on patch 4, which looks trivially correct. > +1 on patch 5, though I agree with peff that it can be omitted in > deference to Ronnie's work.
Thanks. > By the way, while cleaning up in patch 5 you might take the chance to > rename the local variable ref_name to refname to be consistent with most > of our code, but this is by no means required. I had the exact same inclination, but dismissed it as me being too picky. :) I'll change it if I re-roll, but I think we'll end up just dropping that patch entirely. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
