Jonathan Nieder <jrnie...@gmail.com> writes:
> Jeff King wrote:
>
>> It is unfortunately easy for our static header list to grow
>> stale, as none of the regular developers make use of it.
>> Instead of trying to keep it up to date, let's invoke "find"
>> to generate the list dynamically.
>
> Yep, I like this.
>
> It does mean that people who run "make pot" have to be a little more
> vigilant about not keeping around extra .h files by mistake. But I
> trust them.
>
> [...]
>> +LIB_H = $(shell $(FIND) . \
>> + -name .git -prune -o \
>> + -name t -prune -o \
>> + -name Documentation -prune -o \
>> + -name '*.h' -print)
>
> Tiny nit: I might use
>
> $(shell $(FIND) * \
> -name . -o
> -name '.*' -prune -o \
> -name t -prune -o \
> -name Documentation -prune -o \
> -name '*.h' -print)
>
> or
>
> $(shell $(FIND) * \
> -name '.?*' -prune -o \
> -name t -prune -o \
> -name Documentation -prune -o \
> -name '*.h' -print)
>
> to avoid spending time looking in other dot-directories like .svn,
> .hg, or .snapshot.
Wouldn't it be sufficient to start digging not from "*" but from
"??*"? That is, something like
find ??* \( -name Documentation -o -name .\?\* \) -prune -o -name \*.h
;-)
> With or without such a change,
> Reviewed-by: Jonathan Nieder <jrnie...@gmail.com>
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
