Junio C Hamano <gits...@pobox.com> writes: > David Aguilar <dav...@gmail.com> writes: > >> On Mon, Sep 08, 2014 at 12:57:46PM -0700, Junio C Hamano wrote: >>> Matthieu Moy <matthieu....@grenoble-inp.fr> writes: >>> ... >>> > for header in .h ewah/*.h vcs-svn/*.h xdiff/*.h >>> > do >>> > ... >>> > done >>> >>> Yes, that would be even better. Then you wouldn't even have to >>> worry about $IFS dance. >> >> The original motivation was to avoid picking up the generated >> common-cmds.h header file. > > for header > do > case "$header" in $exceptions) continue ;; esac > ... > done > > with comments describing why these exceptions are made would be a > better way to go in such a case.
+1 from me. It would allow developers to use the rule without "git add"-ing new .h files, and the comment would document why the exceptions are there (which missed in the original patch IMHO). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
