Hi Junio,
On Wed, 10 Sep 2014, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes:
>
> > diff --git a/fsck.c b/fsck.c
> > index dd77628..9dd7d12 100644
> > --- a/fsck.c
> > +++ b/fsck.c
> > @@ -237,6 +237,26 @@ static int fsck_tree(struct tree *item, int strict,
> > fsck_error error_func)
> > return retval;
> > }
> >
> > +static int require_end_of_header(const void *data, unsigned long size,
> > + struct object *obj, fsck_error error_func)
> > +{
> > + const char *buffer = (const char *)data;
> > + int i;
> > +
> > + for (i = 0; i < size; i++) {
> > + switch (buffer[i]) {
> > + case '\0':
> > + return error_func(obj, FSCK_ERROR,
> > + "invalid message: NUL at offset %d", i);
>
> Isn't this "invalid header"? After all we haven't escaped this loop
> and haven't seen the message part of the commit object (and it is
> the same if you are going to later reuse this for tag objects).
My reasoning for keeping it saying "message" was that a message consists
of a header and a body. I will change it to "unterminated header" instead,
also in the error message when no NUL was found.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
