On 09/16/2014 09:33 PM, Michael Haggerty wrote:
[]
>
> diff --git a/lockfile.c b/lockfile.c
> index 983c3ec..00c972c 100644
> --- a/lockfile.c
> +++ b/lockfile.c
> @@ -129,6 +129,22 @@ static int lock_file(struct lock_file *lk, const char
> *path, int flags)
> */
> static const size_t max_path_len = sizeof(lk->filename) - 5;
>
> + if (!lock_file_list) {
> + /* One-time initialization */
> + sigchain_push_common(remove_lock_file_on_signal);
> + atexit(remove_lock_file);
> + }
> +
> + if (!lk->on_list) {
> + /* Initialize *lk and add it to lock_file_list: */
> + lk->fd = -1;
> + lk->owner = 0;
> + lk->on_list = 1;
> + lk->filename[0] = 0;
Does it makes sense to change the order here:
Do the full initialization, and once that is completed, set on_list = 1
+ lk->filename[0] = 0;
+ lk->on_list = 1;
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
