On Tue, Oct 07, 2014 at 01:25:54PM +0200, Michael Haggerty wrote: > > +static void object_array_release_entry(struct object_array_entry *ent) > > +{ > > + if (ent->name != object_array_slopbuf) > > + free(ent->name); > > +} > > + > > Would it be a little safer to set ent->name to NULL or to > object_array_slopbuf after freeing the memory, to prevent accidents?
I considered that, but what about the other parts of object_array_entry? Should we NULL the object context pointers, too? The intent of this function is freeing memory, not clearing it for sane reuse. I think I'd be more in favor of a comment clarifying that. It is a static function used only internally by the object-array code. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html