Dennis Kaarsemaker <den...@kaarsemaker.net> writes: > By not clearing the request buffer in stateless-rpc mode, fetch-pack > would keep sending already known-common commits, leading to ever bigger > http requests, eventually getting too large for git-http-backend to > handle properly without filling up the pipe buffer in inflate_request. > --- > I'm still not quite sure whether this is the right thing to do, but make > test still passes :) The new testcase demonstrates the problem, when > running t5551 with EXPENSIVE, this test will hang without the patch to > fetch-pack.c and succeed otherwise.
IIUC, because "stateless" is just that, i.e. the server-end does not keep track of what is already known, not telling what is known to be common in each request would fundamentally break the protocol. Am I mistaken? > fetch-pack.c | 1 - > t/t5551-http-fetch-smart.sh | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+), 1 deletion(-) > > diff --git a/fetch-pack.c b/fetch-pack.c > index 655ee64..258245c 100644 > --- a/fetch-pack.c > +++ b/fetch-pack.c > @@ -410,7 +410,6 @@ static int find_common(struct fetch_pack_args *args, > */ > const char *hex = > sha1_to_hex(result_sha1); > packet_buf_write(&req_buf, > "have %s\n", hex); > - state_len = req_buf.len; > } > mark_common(commit, 0, 1); > retval = 0; > diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh > index 6cbc12d..2aac237 100755 > --- a/t/t5551-http-fetch-smart.sh > +++ b/t/t5551-http-fetch-smart.sh > @@ -245,5 +245,37 @@ test_expect_success EXPENSIVE 'clone the 50,000 tag repo > to check OS command lin > ) > ' > > +test_expect_success EXPENSIVE 'create 50,000 more tags' ' > + ( > + cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" && > + for i in `test_seq 50001 100000` > + do > + echo "commit refs/heads/too-many-refs-again" > + echo "mark :$i" > + echo "committer git <g...@example.com> $i +0000" > + echo "data 0" > + echo "M 644 inline bla.txt" > + echo "data 4" > + echo "bla" > + # make every commit dangling by always > + # rewinding the branch after each commit > + echo "reset refs/heads/too-many-refs-again" > + echo "from :50001" > + done | git fast-import --export-marks=marks && > + > + # now assign tags to all the dangling commits we created above > + tag=$(perl -e "print \"bla\" x 30") && > + sed -e "s|^:\([^ ]*\) \(.*\)$|\2 refs/tags/$tag-\1|" <marks > >>packed-refs > + ) > +' > + > +test_expect_success EXPENSIVE 'fetch the new tags' ' > + ( > + cd too-many-refs && > + git fetch --tags && > + test $(git for-each-ref refs/tags | wc -l) = 100000 > + ) > +' > + > stop_httpd > test_done -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
