Hi Philip, On Thu, 20 Nov 2014, Philip Oakley wrote:
> Are the patches going in the right direction? Yes. A couple of general comments: - please do not comment out code. Just remove it. - the first three commit messages look funny, being indented by 4 spaces... unintentional? > Is the processing of the .obj file in engine.pl sensible? Yes, but instead of adding dead code, it would be better to use the comment "# ignore". I would also strongly suggest to hard-code the complete file name instead of just the extension. We know exactly which file name we want to ignore, and if there should be another .obj file eventually, it would be wrong to ignore it, too. > and the extra care with s/\.o$/.c/ avoiding s/obj/cbj/. Technically, you need to use a group \($\|[ \t]\), but I think that that would be overkill. > Does it affect the Qmake capability? (I've no idea) Frankly, neither do I ;-) But since you touched only engine.pl, I would expect Qmake not to be affected at all, right? > Is the quoting of filenames correct? (my perl foo is cargo cult!) IANAPME (I am not a Perl Monk either), but it looks good to me. > I've also updated the vcbuild/README to mention Msysgit (which > will be replaced soon by the newer/better Git-for-windows/SDK > (https://github.com/git-for-windows/sdk), but the benefits still > apply. The path you used is /msysgit/bin/msvc-build, but the real path would be /bin/msvc-build. > Obviously, the patches will need squashing together, To the contrary, I like the current separation of concerns. Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
