On 11/25/2014 11:56 PM, Stefan Beller wrote:
From: Ronnie Sahlberg <sahlb...@google.com>
Signed-off-by: Ronnie Sahlberg <sahlb...@google.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
---
This was also part of the ongoing series from Ronnie.
But I think the patch in this form is rather independant,
documenting the current state of "git branch -d", so it's
fine to have it in now.
t/t1402-check-ref-format.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/t/t1402-check-ref-format.sh b/t/t1402-check-ref-format.sh
index e5dc62e..08af156 100755
--- a/t/t1402-check-ref-format.sh
+++ b/t/t1402-check-ref-format.sh
@@ -197,4 +197,12 @@ invalid_ref_normalized 'heads///foo.lock'
invalid_ref_normalized 'foo.lock/bar'
invalid_ref_normalized 'foo.lock///bar'
+test_expect_failure 'git branch -d can delete ref with broken sha1' '
+ echo "pointing nowhere" > .git/refs/heads/brokensha1 &&
+ test_when_finished "rm -f .git/refs/heads/brokensha1" &&
+ git branch -d brokensha1 &&
+ git branch >output &&
+ ! grep -e "brokensha1" output
+'
Do we need grep -e here ?
It does not give us anything in the pattern we are using.
-e PATTERN, --regexp=PATTERN
Use PATTERN as the pattern. This can be used to
specify multiple search patterns, or to protect a pattern beginning
with a hyphen (-). (-e is specified by POSIX.)
(And we do not need the "" either, there is no space in brokensha1)
We can simply use:
! grep brokensha1 output
+
test_done
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
