On 11/28/2014 12:18 AM, Jeff King wrote:
On Thu, Nov 27, 2014 at 09:40:08AM -0500, Mark Levedahl wrote:
Then when you add new arguments, the hook has to search through the
parameters looking for one that matches, rather than just checking "$1"
for "amend" (and "$2" for the new option, and so on). As long as the set
of options remains relatively small, I think that is preferable.
We could also just pass them through the environment, which gives nice
named parameters.
See http://comments.gmane.org/gmane.comp.version-control.git/148479 for an
earlier conversation on this exact topic. Also, see
http://permalink.gmane.org/gmane.comp.version-control.git/148480 for a
similar change in git-gui.
Thanks for the links; I had no recollection of that thread.
Unsurprisingly, I like the "HEAD"/"HEAD~1" suggestion. That "peff" guy
seems really clever (and handsome, too, I'll bet).
I'd still be OK with any of the suggestions given in this thread,
though.
-Peff
ars
Apparently our combined handsome-foo was insufficient to get this
accepted way back when, hopefully the current submitter has more :^)
In any event, I've carried the patches using HEAD/HEAD~1 in my tree for
the last 4+ years, have a widely used pre-commit script that depends
upon those. So, I personally would be very happy to see this finally
show up in Junio's tree, would prefer HEAD/HEAD~1 but can adapt to whatever.
Mark
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
