Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

[brian m. carlson]

On Thu, Jan 22, 2015 at 11:05:29PM +0100, Torsten Bögershausen wrote:

We want to support ssh://bmc@2001:470:1f05:79::1/git/bmc/homedir.git/
  because e.g. the Git shipped with Debian (1.7.10.4) (and a lot of other 
installations) supports it.

I understand that this used to work, but it probably shouldn't have ever been accepted. It's nonstandard, and if we accept it for ssh, people will want it to work for https, and due to libcurl, it simply won't. I prefer to see our past acceptance of this format as a bug. This is the first that I've heard of anyone noticing this (since 2013), so it can't be in common usage. If we accept it, we should explicitly document it as being deprecated and note that it's inconsistent with the way everything else works.

We want to support ssh://bmc@[2001:470:1f05:79::1]/git/bmc/homedir.git/
   because that is what other people may expect to work as well:
ssh://bmc@[2001:470:1f05:79::1]:4444/git/bmc/homedir.git/

Everyone expects this to work properly, because it's the standard URL form (RFC 2732). I agree we should support it.

 git push 2001:470:1f05:79::1:1 master
when they mean

 git push [2001:470:1f05:79::1]:1 master

That I don't understand this, where is the path name in your example ?

The path in question is $HOME/1. That's why the bracket notation is obligatory in the short form. I agree it's a bit bizarre.

Everything after the first ':' is the path in the short form:
bmc@hostxx:/git/bmc/homedir.git/

If you really want to use a literal IPV6 with the short form, you must use the 
brackets:
bmc@[2001:470:1f05:79::1]:/git/bmc/homedir.git/
(And you can not have a port number here)

--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Right. In my experience, nobody uses the ssh:// form unless they have to (i.e. they need to use a port number); it's extremely uncommon. So they've already become used to using the bracketed notation, because it's already required for the usual form and it's required in the IPv6 URL standard.

signature.asc
Description: Digital signature