SZEDER Gábor <sze...@ira.uka.de> writes:

>>> @@ -412,7 +412,7 @@ __git_refs_remotes ()
>>>  __git_remotes ()
>>>  {
>>>     local i IFS=$'\n' d="$(__gitdir)"
>>> -   test -d "$d/remotes" && ls -1 "$d/remotes"
>>> +   test -d "$d/remotes" && ls -1 "$d/remotes" 2>/dev/null
>>>     for i in $(git --git-dir="$d" config --get-regexp
>>> 'remote\..*\.url' 2>/dev/null); do
>>>             i="${i#remote.}"
>>>             echo "${i/.url*/}"
>
> Do I smell some bitrotting here?
>
> This function just lists all the defined remotes, first by listing the  
> directories under refs/remotes to get the "legacy" remotes and then  
> loops over 'git config's output to get the "modern" ones.  This  
> predates the arrival of the 'git remote' command in January 2007, so  
> it was really a long time ago.
>
> We should just run 'git remote' instead, shouldn't we?

Perhaps.  Is it sufficient to just make __git_remotes() a thin
wrapper around, i.e.

        __git_remotes ()
        {
                git remotes
        }

or do we need to munge its output further (I didn't look)?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to