On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
<matthieu....@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik....@gmail.com> writes:
>
>> now it works like cd "" which silently succeeds
>
> Missing "." at end of sentence.

And lack of capitalization at the beginning.

More importantly, lack of justification--why is it a good idea to make
"it works like cd ''" in the first place?

>
>>  git.c | 4 +++-
>
> That would probably also deserve a test.

Another "huh?" I had on the actual code was if this counts as "envchanged", if
you are not actually changing the directory at all.

Is this meant as a "micro" for GSoC, by the way?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to