Hi, On Thu, Mar 5, 2015 at 9:51 PM, Luis Ressel <ara...@aixah.de> wrote: > I'm contributing this patch in preparation for a GSoC15 application with > the git project. In particular, I'm interested in the two bisect > improvements listed on the Ideas page. Does anyone have other > suggestions for potential improvements of git bisect that would be > suitable for such a GSoC project?
Last year, on the ideas page: http://git.github.io/SoC-2014-Ideas.html we also had the following improvement: "in some cases, git bisect may test too many merge bases, thus slowing down the bisection (making it closer to linear than logarithmic)." so you could work on that too. And if you really want and have time you can also rewrite git-bisect.sh into a builtin command. There is already builtin/bisect--helper.c where you can put some migrated code step by step. > Oh, and should I add a testcase for the new functionality introduced by > this patch? And if yes, what exactly should I test? First, it looks like another student started working on the same microproject. Did you have a look at what he did? If you didn't, you probably should, so that reviewers don't need to tell you what they already told the other student. And if you did, you should tell it, and maybe explain what you did differently and why. If it looks like the other student is more advanced on this subject, you might want to try another microproject. And if all the microprojects are already taken, you might want to ask the list for other microprojects, or you may want to have a look at the many merge bases improvement above. (You could start by having a look at check_merge_bases() in "bisect.c" and by creating a script or better a test case that reproduces the problem, see t/t6030-bisect-porcelain.sh.) Welcome to the Git community! Best, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
