I  observe that filter is going out of scope, but the
implementation proposed in this patch produces just a
crash instead of any helpful fix.

Signed-off-by: Stefan Beller <sbel...@google.com>
---
 entry.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/entry.c b/entry.c
index 1eda8e9..5383001 100644
--- a/entry.c
+++ b/entry.c
@@ -152,8 +152,10 @@ static int write_entry(struct cache_entry *ce,
                if (filter &&
                    !streaming_write_entry(ce, path, filter,
                                           state, to_tempfile,
-                                          &fstat_done, &st))
+                                          &fstat_done, &st)) {
+                       free_stream_filter(filter);
                        goto finish;
+               }
        }
 
        switch (ce_mode_s_ifmt) {
-- 
2.3.0.81.gc37f363

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to