karthik nayak <karthik....@gmail.com> writes: > + type = type_from_string_gently(buf, len, 1); > + if (oi->typename) { > + strbuf_add(oi->typename, buf, len); > + strbuf_addch(oi->typename, '\0');
add() has setlen() at the end so you do not have to NUL terminate it yourself. Doing addch() is actively wrong, as oi->typename->len now counts the terminating NUL as part of the string, no? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html