Stefan Beller <sbel...@google.com> writes:
> On Thu, Apr 23, 2015 at 10:56 AM, Junio C Hamano <gits...@pobox.com> wrote:
>
>>> + int save_errno = errno;
>>> + error("Couldn't reopen %s", lock->lk->filename.buf);
>>
>> No need to change this line, but I noticed that we might want to do
>> something about the first one of the following two:
>
> I personally like to have each error(...) to have a unique string, such
> that when you run into trouble (most likely reported by a user),
> you can easily pinpoint where the exact error is.
I was hoping that the "grep" patterns were strong enough hint, but
let me be explicit. I was commenting on "Could" not being spelled
as "could".
>> $ git grep -e '[ ]error(_*"[A-Z]' | wc -l
>> 146
>> $ git grep -e '[ ]error(_*"[a-z]' | wc -l
>> 390
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
