On Mon, Apr 27, 2015 at 10:31:28AM -0700, Junio C Hamano wrote: > Fredrik Gustafsson <iv...@iveqy.com> writes: > > > I agree that it is very clear once you do edit the commit message. My main > > point with this patch was to clarify -v, since it's not obvious from the > > documentation that it will be removed. > > While I agree with you that the documentation should make it clear > that the patch will not be part of the commit, I think the root > cause of the current "unclear-ness" is because the documentation > does not make it clear *WHY* the "-v" option gives the patch text > there.
I agree. > > Doing something like this on top of your patch may clarify the > reason what "-v" is used for, and I suspect that it may even make it > unnecessary to explicitly say that the patch text will not be part > of the log message (but I didn't remove that with this "how about > this" follow-up). Even better. I would be glad if this could make it into a release. Thanks for the feedback, to make this a good patch. -- Fredrik Gustafsson phone: +46 733-608274 e-mail: iv...@iveqy.com website: http://www.iveqy.com -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
