On Thu, May 21, 2015 at 4:48 PM, Allen Hubbe <alle...@gmail.com> wrote: > My motivation for this patch was not really to support the sendmail > aliases file directly. The commit message may therefore be > misleading. So, I could also rewrite the commit message to say > something like, "loosely based on" the sendmail aliases format, if the > exceptions to the format in the current message are not enough.
That probably would be a good idea. After reading the 'aliases' man page you cited[1], I was wondering why your parser diverged from it in so many ways. In addition to lack of support for folded lines, your format: * only recognizes comment lines when '#' is the first character, whereas [1] allows whitespace before '#' * only recognizes zero-length lines as empty, whereas [1] more loosely interprets a whitespace-only line as empty * doesn't support quoting the 'name' part of "name: value" as [1] does > Really, I just prefer the simpler <alias>: <email|alias> syntax > instead of the ones for mutt, elm, etc, and that is why I wrote this > patch. Your patch is missing a documentation update (Documentation/git-send-email.txt) and new tests (t/t9001-send-email.sh). [1] http://www.postfix.org/aliases.5.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
