On Thu, May 21, 2015 at 5:53 PM, Jeff King <p...@peff.net> wrote: > Commit f86a374 (pack-bitmap.c: fix a memleak, 2015-03-30) > noticed that we leak the "result" bitmap. But we should use > "bitmap_free" rather than straight "free", as the former > remembers to free the bitmap array pointed to by the struct. > > Signed-off-by: Jeff King <p...@peff.net> > --- > Sorry, I should have noticed this when reviewing the original.
No need to be sorry, me too. This looks good to me. > > pack-bitmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pack-bitmap.c b/pack-bitmap.c > index 62a98cc..d64bd94 100644 > --- a/pack-bitmap.c > +++ b/pack-bitmap.c > @@ -987,7 +987,7 @@ void test_bitmap_walk(struct rev_info *revs) > else > fprintf(stderr, "Mismatch!\n"); > > - free(result); > + bitmap_free(result); > } > > static int rebuild_bitmap(uint32_t *reposition, > -- > 2.4.1.528.g00591e3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
