On Thu, May 21, 2015 at 11:40:44AM -0700, Junio C Hamano wrote:
> Heiko Voigt <hvo...@hvoigt.net> writes:
>
> > This is finally the next iteration of the submodule config api. The last
> > iteration can be found here:
> >
> > http://article.gmane.org/gmane.comp.version-control.git/252601
> >
> > This iteration fixes the lookup of submodules by name
> > (submodule_from_name()) where one needed to pass in the gitmodule sha1
> > by mistake. To keep it simple for the user and behave as documented we
> > should take the commit sha1 which is now fixed here. We now also test
> > the lookup by name in the api tests.
> >
> > This should be ready for inclusion.
> >
> > Cheers Heiko
> >
> > Here is the interdiff to the last iteration:
> >
> > diff --git a/submodule-config.c b/submodule-config.c
> > index 96623ad..177767d 100644
> > --- a/submodule-config.c
> > +++ b/submodule-config.c
> > @@ -25,6 +25,11 @@ struct submodule_entry {
> > struct submodule *config;
> > };
> >
> > +enum lookup_type {
> > + lookup_name,
> > + lookup_path,
> > +};
>
> Please lose the comma after the last element in enum. Some
> compilers do not like it, I was told.
Fixed.
> > + switch (lookup_type) {
> > + case lookup_name:
> > + submodule = cache_lookup_name(cache, sha1, key);
> > + break;
> > + case lookup_path:
> > + submodule = cache_lookup_path(cache, sha1, key);
> > + break;
>
> Is this too deeply indented?
It seems I accidentially used vim's default indenting. Fixed.
Will wait a little longer if there are more comments than the style
fixes before sending another iteration.
Cheers Heiko
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
