On Sun, May 31, 2015 at 10:04 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Sat, May 30, 2015 at 7:53 PM, Karthik Nayak <karthik....@gmail.com> wrote: >> >> -static void sort_refs(struct ref_sort *sort, struct ref_array *array) >> +void sort_ref_array(struct ref_sort *sort, struct ref_array *array) > > It is probably better to call the above function ref_array_sort()... > > [...] > >> -static struct ref_sort *default_sort(void) >> +/* If no sorting option is given, use refname to sort as default */ >> +struct ref_sort *ref_default_sort(void) > > ... especially since you call the above ref_default_sort()... > >> -static int opt_parse_sort(const struct option *opt, const char *arg, int >> unset) >> +int opt_parse_ref_sort(const struct option *opt, const char *arg, int unset) > > ... and the above opt_parse_sort().
After saying that I realize that these two other functions are not doing the same thing. This might suggest that they are not named very well as well. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
