Karthik Nayak <karthik....@gmail.com> writes:

> +struct ref_filter_cbdata {
> +     struct ref_array array;
> +     struct ref_filter filter;
> +};

I didn't notice this at first, but why introduce the structure like this
when you are going to turn it into pointers later in PATCH 7:

Karthik Nayak <karthik....@gmail.com> writes:

> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -42,12 +45,17 @@ struct ref_filter {
>  };
>  
>  struct ref_filter_cbdata {
> -     struct ref_array array;
> -     struct ref_filter filter;
> +     struct ref_array *array;
> +     struct ref_filter *filter;
>  };

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to